Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws[patch]: support ChatBedrock(max_tokens, temperature) #226

Merged
merged 2 commits into from
Oct 4, 2024
Merged

aws[patch]: support ChatBedrock(max_tokens, temperature) #226

merged 2 commits into from
Oct 4, 2024

Conversation

baskaryan
Copy link
Collaborator

No description provided.

efriis
efriis approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the standard params standard unit test still fail? Could we un-xfail it after this?

@baskaryan
Copy link
Collaborator Author

does the standard params standard unit test still fail? Could we un-xfail it after this?

which test

@baskaryan baskaryan merged commit ba30daa into main Oct 4, 2024
12 checks passed
@baskaryan baskaryan deleted the bagatur/support_bedrock_max_tokens_temp branch October 4, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efriis efriis efriis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baskaryan @efriis